at date of this post
patched wp_w3all.php
function wp_w3all_phpbb_iframe_shortif()
to correctly manage the iframe shortcode detection when the wordpress installed into root and not a subfolder, and modify strpos use into same function, to not throw a php notice if wp running in debug mode
to update and fix if needed, and before 2.6.0 release, download the file here:
https://plugins.trac.wordpress.org/expo ... _w3all.php
and replace into
/wp-content/plugins/wp-w3all-phpbb-integration/wp_w3all.php
report all 2.5.9 bugs!
Coming 2.6.0 logs and 2.5.9 patches/bugs
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
Re: Coming 2.6.0 logs and 2.5.9 patches/bugs
new shortcode/widget (online users and forums stats):
forum's online users and forums stats (with avatars or not)
values of this result, will be used to detect on shortcodes and widgets, also, if the poster is actually online or not and display it (if option active in shortcode param or widget)
should add option:
phpBB groups WP roles auto switch: when user change phpBB group or WP role, the same will happen into related cms
and
retrieve all groups which the user belong to, not only the default one, if there are more, so to improve all the logic about shortcodes and widgets views permissions.
These values will be retrieved within existent query, and maybe only if option active
forum's online users and forums stats (with avatars or not)
values of this result, will be used to detect on shortcodes and widgets, also, if the poster is actually online or not and display it (if option active in shortcode param or widget)
should add option:
phpBB groups WP roles auto switch: when user change phpBB group or WP role, the same will happen into related cms
and
retrieve all groups which the user belong to, not only the default one, if there are more, so to improve all the logic about shortcodes and widgets views permissions.
These values will be retrieved within existent query, and maybe only if option active
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
Re: Coming 2.6.0 logs and 2.5.9 patches/bugs
Fix:
Looking the logic to retrieve avatars when listing stats and phpBB users into widget, i see there is a bug into (the logic):
the code that setup avatars values, at one specific point, get values from phpBB, but not emails, then on subsequent get the wp user by user_login.
That's wrong because the integration can also run as mismatching username. The email value as been added and the user will be retrieved by email.
Looking the logic to retrieve avatars when listing stats and phpBB users into widget, i see there is a bug into (the logic):
the code that setup avatars values, at one specific point, get values from phpBB, but not emails, then on subsequent get the wp user by user_login.
That's wrong because the integration can also run as mismatching username. The email value as been added and the user will be retrieved by email.
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
Re: Coming 2.6.0 logs and 2.5.9 patches/bugs
Fix: multisite user deletion (unescaped string on query on certain php versions)
viewtopic.php?p=5620#p5620
viewtopic.php?p=5620#p5620
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
Re: Coming 2.6.0 logs and 2.5.9 patches/bugs
IFRAME page forum and awesome shortcode improvements:
It just require to search and replace/substitute
scrollCallback
into page-forum and /views/wp_w3all_phpbb_iframe_short.php
substituting it as suggested: onScroll
I note also a problem, that need to be resolved:
let say we have an iframe shortcoded that we place into a page like this:
https://www.axew3.com/w3/2022/02/the-aw ... shortcode/
on this wp post, you see the page load reposition to 100 px top and not where the iframe is bacause the top_gap param has not been set into the shortcode.
This is exactly what i want (not exactly, i do not want nor 100px of scroll, i would not have scroll at all). SO it present a problem:
since the top gap param has not been set (because i do not want this page positioned to the iframe when load), when i click into an iframe link, as obvious, the page scroll to top (because top_gap default value if not set is 100(px)).
Another param for this shortcode will be added to manage this aspect.
The param scroll_default has been added so that when used and set to no
scroll_default="no"
avoid the iframe to scroll
https://www.axew3.com/w3/2022/02/the-aw ... shortcode/
the js code on page forum (so related same shortcode code) require to be updated to the new way the resizer lib will require.[iFrameSizer][Host page: w3all_phpbb_iframe] Deprecated: 'scrollCallback' has been renamed 'onScroll'. The old method will be removed in the next major version.
It just require to search and replace/substitute
scrollCallback
into page-forum and /views/wp_w3all_phpbb_iframe_short.php
substituting it as suggested: onScroll
I note also a problem, that need to be resolved:
let say we have an iframe shortcoded that we place into a page like this:
https://www.axew3.com/w3/2022/02/the-aw ... shortcode/
on this wp post, you see the page load reposition to 100 px top and not where the iframe is bacause the top_gap param has not been set into the shortcode.
This is exactly what i want (not exactly, i do not want nor 100px of scroll, i would not have scroll at all). SO it present a problem:
since the top gap param has not been set (because i do not want this page positioned to the iframe when load), when i click into an iframe link, as obvious, the page scroll to top (because top_gap default value if not set is 100(px)).
Another param for this shortcode will be added to manage this aspect.
The param scroll_default has been added so that when used and set to no
scroll_default="no"
avoid the iframe to scroll
https://www.axew3.com/w3/2022/02/the-aw ... shortcode/
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
Re: Coming 2.6.0 logs and 2.5.9 patches/bugs
The shortcode param security_token
move to be usable into any shortcode where it is applied (at moment only iframe shortcode and online users/stats). It seem to me a good idea for several reasons. Isn't it?
WP_W3ALL integration plugin iframe integration/widgets/shortcodes, can be used to display contents from any site into another, also cross domain, and not used only to integrate WP and phpBB
move to be usable into any shortcode where it is applied (at moment only iframe shortcode and online users/stats). It seem to me a good idea for several reasons. Isn't it?
WP_W3ALL integration plugin iframe integration/widgets/shortcodes, can be used to display contents from any site into another, also cross domain, and not used only to integrate WP and phpBB
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
Re: Coming 2.6.0 logs and 2.5.9 patches/bugs
again fixed at date of this post. I am sorry that unfortunately the code i had think had been already patched, instead was not on repository.axew3 wrote: ↑Tue Mar 08, 2022 8:48 amFix: multisite (and signups) user deletion (unescaped string on query on certain php versions)
viewtopic.php?p=5620#p5620
so that to fix, until 2.6.0 not released, you should download the file class.wp.w3all-phpbb.php
https://plugins.trac.wordpress.org/expo ... -phpbb.php
and replace into
/wp-content/plugins/wp-w3all-phpbb-integration/class.wp.w3all-phpbb.php
all under this (and more) has been fixed now
- axew3
- w3all User
- Posts: 2568
- Joined: Fri Jan 22, 2016 5:15 pm
- Location: Italy
- Contact:
Re: Coming 2.6.0 logs and 2.5.9 patches/bugs
Improvements all over about avatars into widgets and shortcodes.
avatars images rendered with proper alt tag, functions cleaned up (admin screen) and several fixes applied all over.
to be done, avatars images rendered with proper alt actually only into last stats widget
The new widget that retrieve online users and execute the fast query is conveniently executed on init hook, just only when required and if widget active.
The widget will contain: avatars of online users, with their username
posts count
topics count
max num of users online
new user's pm (if there are)
tot users
each of these can be easily removed, or more can be easily added.
Widget option: are avatar dimension, avatar yes/no, usernames links (that points to user's profile in phpBB).
Do not think it is good to add options and options that anyone can add easily, so the file
/views/phpbb_uonline_stats.php will contain only the minimum necessary, then anyone can customize as more like or leave as is, because already very nice!
to be done, avatars images rendered with proper alt actually only into last stats widget
The new widget that retrieve online users and execute the fast query is conveniently executed on init hook, just only when required and if widget active.
The widget will contain: avatars of online users, with their username
posts count
topics count
max num of users online
new user's pm (if there are)
tot users
each of these can be easily removed, or more can be easily added.
Widget option: are avatar dimension, avatar yes/no, usernames links (that points to user's profile in phpBB).
Do not think it is good to add options and options that anyone can add easily, so the file
/views/phpbb_uonline_stats.php will contain only the minimum necessary, then anyone can customize as more like or leave as is, because already very nice!